Use setsid resume.py to reduce reconfigure time#4436
Merged
samskillman merged 1 commit intoJul 28, 2025
Conversation
1fb7efb to
74a8128
Compare
Collaborator
Author
|
Failure looks unrelated |
74a8128 to
cd3777f
Compare
Using setsid instead of disown unlinks the resume.py process from the parent (slurmctld) process, allowing scontrol reconfigure to continue prior to the resume.py process exiting.
cd3777f to
b8f7d74
Compare
mr0re1
approved these changes
Jul 28, 2025
4889560
into
GoogleCloudPlatform:develop
34 of 62 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using setsid instead of disown unlinks the resume.py process from the parent (slurmctld) process, allowing scontrol reconfigure to continue prior to the resume.py process exiting.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.