Skip to content

Revert "Minimize tf drift for spot instances during re-deploy"#4435

Merged
mr0re1 merged 1 commit into
developfrom
revert-4430-fix/spot-instance-config-default
Jul 22, 2025
Merged

Revert "Minimize tf drift for spot instances during re-deploy"#4435
mr0re1 merged 1 commit into
developfrom
revert-4430-fix/spot-instance-config-default

Conversation

@mr0re1

@mr0re1 mr0re1 commented Jul 22, 2025

Copy link
Copy Markdown
Collaborator

Reverts #4430

Makes pr-test-slurm-gcp-v6-simple-job-completion to fail with:

Error: Error creating instance template: googleapi: Error 400: Invalid value for field 'resource.properties.scheduling.instanceTerminationAction': 'STOP'. You cannot specify a termination action for a VM instance that has the standard provisioning model (default). To use instance termination action, the VM instance must use the Spot or Reservation-Bound provisioning model., invalid

  with module.slurm_controller.module.slurm_nodeset_template["nodeset"].module.instance_template.google_compute_instance_template.tpl,
  on modules/embedded/community/modules/internal/slurm-gcp/internal_instance_template/main.tf line 70, in resource "google_compute_instance_template" "tpl":
  70: resource "google_compute_instance_template" "tpl" {

@mr0re1 mr0re1 requested review from a team and samskillman as code owners July 22, 2025 23:01
@mr0re1 mr0re1 added the release-chore To not include into release notes label Jul 22, 2025
@mr0re1 mr0re1 enabled auto-merge July 22, 2025 23:06
@mr0re1 mr0re1 merged commit 45d12af into develop Jul 22, 2025
12 of 65 checks passed
@mr0re1 mr0re1 deleted the revert-4430-fix/spot-instance-config-default branch July 22, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-chore To not include into release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants