Skip to content

refactor a3m slurm ubuntu solutions into 1 blueprint#4216

Merged
tpdownes merged 1 commit into
GoogleCloudPlatform:developfrom
RachaelSTamakloe:refactor_a3m_slurm_solution
May 30, 2025
Merged

refactor a3m slurm ubuntu solutions into 1 blueprint#4216
tpdownes merged 1 commit into
GoogleCloudPlatform:developfrom
RachaelSTamakloe:refactor_a3m_slurm_solution

Conversation

@RachaelSTamakloe

@RachaelSTamakloe RachaelSTamakloe commented May 30, 2025

Copy link
Copy Markdown
Collaborator

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@RachaelSTamakloe RachaelSTamakloe requested a review from tpdownes May 30, 2025 13:53
@RachaelSTamakloe RachaelSTamakloe self-assigned this May 30, 2025
@RachaelSTamakloe RachaelSTamakloe requested review from a team and samskillman as code owners May 30, 2025 13:53
@RachaelSTamakloe RachaelSTamakloe added the release-improvements Added to release notes under the "Improvements" heading. label May 30, 2025
@RachaelSTamakloe RachaelSTamakloe force-pushed the refactor_a3m_slurm_solution branch 4 times, most recently from 3bfe79e to bde6605 Compare May 30, 2025 14:52
@RachaelSTamakloe RachaelSTamakloe removed their assignment May 30, 2025
@RachaelSTamakloe RachaelSTamakloe force-pushed the refactor_a3m_slurm_solution branch from 36fb246 to a282476 Compare May 30, 2025 16:42
tpdownes
tpdownes approved these changes May 30, 2025
View reviewed changes

@tpdownes tpdownes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work to refactor this while supporting existing customers using the Debian solution!

@tpdownes tpdownes merged commit 438464d into GoogleCloudPlatform:develop May 30, 2025
14 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samskillman samskillman Awaiting requested review from samskillman

1 more reviewer

@tpdownes tpdownes tpdownes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@RachaelSTamakloe RachaelSTamakloe

Labels

release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RachaelSTamakloe @tpdownes