remove gvnic-1 from pods manifests#4088
Merged
Merged
Conversation
Contributor
Author
the 2nd gvnic is not needed by NCCL
Contributor
Author
|
@ighosh98 could you take a look of this change. We are removing gvnic-1 from the recommended pod manifest. We've meregd the similar change GoogleCloudPlatform/container-engine-accelerators#492 |
Contributor
|
/gcbrun |
Contributor
|
@liuyuan10 Could you also add a reason for this change? Will approve if integration tests pass. |
Contributor
Author
@ighosh98 I have that in the commit message. the 2nd gvnic is not needed by NCCL so no need to pass them to the workloads in general |
ighosh98
approved these changes
May 13, 2025
SwarnaBharathiMantena
approved these changes
May 13, 2025
Contributor
|
@liuyuan10 Should it be removed from the A4 nccl jobset example too? |
Contributor
Author
Yes. it's already included in the commit. @SwarnaBharathiMantena |
ighosh98
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the 2nd gvnic is not needed by NCCL
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.