Skip to content

Remove instance image override at the top of cae.yaml example#4066

Merged
abbas1902 merged 1 commit into
GoogleCloudPlatform:developfrom
abbas1902:cae
May 6, 2025
Merged

Remove instance image override at the top of cae.yaml example#4066
abbas1902 merged 1 commit into
GoogleCloudPlatform:developfrom
abbas1902:cae

Conversation

@abbas1902

Copy link
Copy Markdown
Collaborator

The Computer Aided Engineering (CAE) example makes use of chrome-remote-desktop as a means to visualize computational output. Currently the module intends to run a Debian as that is among the supported operating systems for chrome-remote-desktop. The value gets overwritten by the top level declaration which uses the Slurm Rocky 8 image. This PR removes that image overriding so that the chrome-remote-desktop in the example deploys with the intended image and the startup scripts can run and complete.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@abbas1902 abbas1902 added the release-bugfix Added to release notes under the "Bug fixes" heading. label May 6, 2025
@abbas1902 abbas1902 marked this pull request as ready for review May 6, 2025 01:04
@abbas1902 abbas1902 requested review from a team and samskillman as code owners May 6, 2025 01:04
@abbas1902 abbas1902 requested a review from harshthakkar01 May 6, 2025 16:26
@harshthakkar01

Copy link
Copy Markdown
Contributor

lets make sure the test passes.

@abbas1902 abbas1902 merged commit 66c6679 into GoogleCloudPlatform:develop May 6, 2025
15 of 68 checks passed
@abbas1902 abbas1902 deleted the cae branch May 6, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-bugfix Added to release notes under the "Bug fixes" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants