Skip to content

Allow deploying cluster without live reservation#4057

Merged
vikramvs-gg merged 1 commit into
GoogleCloudPlatform:developfrom
vikramvs-gg:reservation_validation_changes
May 21, 2025
Merged

Allow deploying cluster without live reservation#4057
vikramvs-gg merged 1 commit into
GoogleCloudPlatform:developfrom
vikramvs-gg:reservation_validation_changes

Conversation

@vikramvs-gg

Copy link
Copy Markdown
Contributor

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@vikramvs-gg vikramvs-gg requested review from a team and samskillman as code owners May 5, 2025 11:20
@vikramvs-gg vikramvs-gg marked this pull request as draft May 7, 2025 03:44
@vikramvs-gg vikramvs-gg added the release-module-improvements Added to release notes under the "Module Improvements" heading. label May 7, 2025
@vikramvs-gg vikramvs-gg marked this pull request as ready for review May 15, 2025 08:55
@vikramvs-gg vikramvs-gg force-pushed the reservation_validation_changes branch from cc01b44 to e81d9bc Compare May 15, 2025 13:16
@vikramvs-gg vikramvs-gg requested a review from ighosh98 May 15, 2025 13:40
Comment thread tools/cloud-build/daily-tests/builds/gke-inactive-reservation.yaml Outdated
ighosh98
ighosh98 previously approved these changes May 19, 2025
Comment thread modules/compute/gke-node-pool/main.tf Outdated

@SwarnaBharathiMantena SwarnaBharathiMantena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vikramvs-gg vikramvs-gg force-pushed the reservation_validation_changes branch from 2c125e7 to 835cb78 Compare May 21, 2025 06:50
@vikramvs-gg vikramvs-gg merged commit c23eb5c into GoogleCloudPlatform:develop May 21, 2025
11 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-module-improvements Added to release notes under the "Module Improvements" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants