Make additional disk params optional#4056
Merged
annuay-google merged 1 commit intoMay 6, 2025
Merged
Conversation
ankitkinra
reviewed
May 5, 2025
ankitkinra
approved these changes
May 5, 2025
mr0re1
reviewed
May 5, 2025
mr0re1
approved these changes
May 6, 2025
7ac9892
into
GoogleCloudPlatform:develop
20 of 75 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/compute_instance_template#nested_disk
These are truly optional parameters in GCP terraform and APIs. You needn't specify anything, and GCP will figure it out- we're just exposing the full functionality to users here.