Skip to content

Remove k8s service account var from gke-a3U blueprint#4024

Merged
ighosh98 merged 2 commits into
GoogleCloudPlatform:developfrom
parulbajaj01:parul/gke-enhancements
Apr 30, 2025
Merged

Remove k8s service account var from gke-a3U blueprint#4024
ighosh98 merged 2 commits into
GoogleCloudPlatform:developfrom
parulbajaj01:parul/gke-enhancements

Conversation

@parulbajaj01

Copy link
Copy Markdown
Contributor

We are not using this var anywhere in the blueprint and are hardcoding the value. Moreover, it's not very clear to the users what's the purpose of this and what value should be inputted. So removing this will be better.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@parulbajaj01 parulbajaj01 added the release-improvements Added to release notes under the "Improvements" heading. label Apr 30, 2025
@parulbajaj01 parulbajaj01 requested review from a team and samskillman as code owners April 30, 2025 06:01
@ighosh98 ighosh98 enabled auto-merge April 30, 2025 06:16
@ighosh98 ighosh98 merged commit 774c131 into GoogleCloudPlatform:develop Apr 30, 2025
11 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants