fix(htcondor): explicitly set region for cm and ap addresses to match subnetwork region#3991
Merged
tpdownes merged 1 commit intoApr 24, 2025
Conversation
Contributor
|
/gcbrun |
rohitramu
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in the scheduler htcondor module where google_compute_address resources for both the Access Point (ap) and Central Manager (cm) were created without an explicitly defined region.
Problem :
When deploying in a multi-region setup, the google_compute_address resources default to the region specified in the provider block. However, the associated subnetwork may belong to a different region. This led to the following deployment error :
Fix
The fix explicitly sets the region attribute for both ap and cm address resources to use var.region, ensuring that they are provisioned in the same region as the subnetwork (var.subnetwork_self_link).
Changes
Added
region = var.regionto the google_compute_address "ap" resource in the Access Point moduleAdded
region = var.regionto the google_compute_address "cm" resource in the Central Manager moduleThis ensures compatibility and correctness in multi-region deployments.