Skip to content

Add support for optional GCS bucket module config#3990

Merged
mohitchaurasia91 merged 7 commits into
GoogleCloudPlatform:developfrom
mohitchaurasia91:gcs-module-changes
Apr 24, 2025
Merged

Add support for optional GCS bucket module config#3990
mohitchaurasia91 merged 7 commits into
GoogleCloudPlatform:developfrom
mohitchaurasia91:gcs-module-changes

Conversation

@mohitchaurasia91

@mohitchaurasia91 mohitchaurasia91 commented Apr 23, 2025

Copy link
Copy Markdown
Contributor

PR include changes to support following optional GCS bucket module config

  • var uniform_bucket_level_access with default value set to true for backward compatibility.
  • var storage_class with default value set to REGIONAL for backward compatibility.
  • var autoclass with default value set to enabled = false
  • var public_access_prevention with unset default value
  • var soft_delete_retention_duration with unset default value
  • var enable_versioning with default value set to false
  • var lifecycle_rules with default value set to []
  • var retention_policy_period with unset default value
  • var enable_object_retention with default value set to false

Reference

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@mohitchaurasia91 mohitchaurasia91 added the release-module-improvements Added to release notes under the "Module Improvements" heading. label Apr 23, 2025
@mohitchaurasia91 mohitchaurasia91 self-assigned this Apr 23, 2025
@mohitchaurasia91 mohitchaurasia91 changed the title Add support for optional GCS bucket module config. Add support for optional GCS bucket module config Apr 24, 2025
@mohitchaurasia91 mohitchaurasia91 marked this pull request as ready for review April 24, 2025 07:54
@mohitchaurasia91 mohitchaurasia91 requested review from a team and samskillman as code owners April 24, 2025 07:54
ighosh98
ighosh98 previously approved these changes Apr 24, 2025
Comment thread community/modules/file-system/cloud-storage-bucket/variables.tf Outdated
@mohitchaurasia91 mohitchaurasia91 merged commit 901e3ea into GoogleCloudPlatform:develop Apr 24, 2025
@mohitchaurasia91 mohitchaurasia91 deleted the gcs-module-changes branch April 24, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-module-improvements Added to release notes under the "Module Improvements" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants