Skip to content

Enable specification of system node pool zones in the GKE Cluster module#3976

Merged
SwarnaBharathiMantena merged 1 commit into
GoogleCloudPlatform:developfrom
ndebuhr:feat/system-node-pool-zones
Apr 23, 2025
Merged

Enable specification of system node pool zones in the GKE Cluster module#3976
SwarnaBharathiMantena merged 1 commit into
GoogleCloudPlatform:developfrom
ndebuhr:feat/system-node-pool-zones

Conversation

@ndebuhr

@ndebuhr ndebuhr commented Apr 19, 2025

Copy link
Copy Markdown
Contributor

A common pattern with GKE is to use a regional control plane, but nodes in a single zone. This makes most control plane operations a zero-downtime event and offers redundancy, but keeps actual workloads zonally colocated for latency reduction, inter-zone traffic reduction, and simplified storage classes (i.e., no regional disks or volume node affinity complexities). This is especially true for HPC/GPU/TPU node pools, but is also true for "system" components.

At present, this pattern is not possible with the GKE Cluster module system node pool, as the underlying Terraform module's node_locations setting, which override's the cluster's default zones, is not exposed.

This PR introduces a variable to optionally define specific system node pool zones. As this is an optional variable with null default, the module's default behavior and existing setups are unaffected.

Please take the following actions before submitting this pull request.

  • ✅ Fork your PR branch from the Toolkit "develop" branch (not main)
  • ✅ Test all changes with pre-commit in a local branch #
  • ✅ Confirm that "make tests" passes all tests
  • ✅ Add or modify unit tests to cover code changes
  • ✅ Ensure that unit test coverage remains above 80%
  • ✅ Update all applicable documentation
  • ✅ Follow Cluster Toolkit Contribution guidelines #

@ndebuhr ndebuhr requested review from a team and samskillman as code owners April 19, 2025 20:43

@SwarnaBharathiMantena SwarnaBharathiMantena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parulbajaj01 parulbajaj01 self-requested a review April 23, 2025 10:33

@parulbajaj01 parulbajaj01 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SwarnaBharathiMantena SwarnaBharathiMantena added the release-module-improvements Added to release notes under the "Module Improvements" heading. label Apr 23, 2025
@SwarnaBharathiMantena SwarnaBharathiMantena merged commit 82b1499 into GoogleCloudPlatform:develop Apr 23, 2025
@ndebuhr ndebuhr deleted the feat/system-node-pool-zones branch April 23, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-module-improvements Added to release notes under the "Module Improvements" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants