Enable specification of system node pool zones in the GKE Cluster module#3976
Merged
SwarnaBharathiMantena merged 1 commit intoApr 23, 2025
Conversation
SwarnaBharathiMantena
approved these changes
Apr 23, 2025
SwarnaBharathiMantena
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Here are terraform links for reference:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A common pattern with GKE is to use a regional control plane, but nodes in a single zone. This makes most control plane operations a zero-downtime event and offers redundancy, but keeps actual workloads zonally colocated for latency reduction, inter-zone traffic reduction, and simplified storage classes (i.e., no regional disks or volume node affinity complexities). This is especially true for HPC/GPU/TPU node pools, but is also true for "system" components.
At present, this pattern is not possible with the GKE Cluster module system node pool, as the underlying Terraform module's
node_locationssetting, which override's the cluster's default zones, is not exposed.This PR introduces a variable to optionally define specific system node pool zones. As this is an optional variable with null default, the module's default behavior and existing setups are unaffected.
Please take the following actions before submitting this pull request.