GKE DWS Flex Start consumption option examples#3968
Merged
ighosh98 merged 1 commit intoMay 8, 2025
Merged
Conversation
6062a25 to
b30bacd
Compare
7f94beb to
c35abbc
Compare
e0640bc to
f351dc8
Compare
Contributor
|
I only see A3U blueprints. Are there any other machine types we should be supporting? |
ighosh98
suggested changes
May 8, 2025
ighosh98
left a comment
Contributor
There was a problem hiding this comment.
- Please add the
nccl-installerin all the modules and blueprints that are created - Remove on-demand blueprints
- Add remaining integration tests.
Contributor
|
Remove on-demand and spot blueprints till we are able to test these out. Remove integration tests until we receive the allowlisting. |
Contributor
|
Changes LGTM high level |
Contributor
Author
Will create a separate PR for integration tests. |
d4bff50 to
64a7b78
Compare
ighosh98
previously approved these changes
May 8, 2025
af741bd to
47b09f5
Compare
ighosh98
approved these changes
May 8, 2025
Contributor
Author
|
Updated the title upon a request to remove DWS Calendar at this time. #4090 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.