Skip to content

GKE DWS Flex Start consumption option examples#3968

Merged
ighosh98 merged 1 commit into
GoogleCloudPlatform:developfrom
SwarnaBharathiMantena:swarnabm/gke_node_consumption
May 8, 2025
Merged

GKE DWS Flex Start consumption option examples#3968
ighosh98 merged 1 commit into
GoogleCloudPlatform:developfrom
SwarnaBharathiMantena:swarnabm/gke_node_consumption

Conversation

@SwarnaBharathiMantena

Copy link
Copy Markdown
Contributor

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@SwarnaBharathiMantena SwarnaBharathiMantena added the release-module-improvements Added to release notes under the "Module Improvements" heading. label Apr 18, 2025
@SwarnaBharathiMantena SwarnaBharathiMantena force-pushed the swarnabm/gke_node_consumption branch from 6062a25 to b30bacd Compare April 29, 2025 09:39
@SwarnaBharathiMantena SwarnaBharathiMantena changed the title Support dws flex start flag in gke nodepool module and add dws consumption examples GKE consumption option examples Apr 29, 2025
@SwarnaBharathiMantena SwarnaBharathiMantena added release-improvements Added to release notes under the "Improvements" heading. and removed release-module-improvements Added to release notes under the "Module Improvements" heading. labels Apr 29, 2025
@SwarnaBharathiMantena SwarnaBharathiMantena force-pushed the swarnabm/gke_node_consumption branch from 7f94beb to c35abbc Compare April 30, 2025 05:33
@SwarnaBharathiMantena SwarnaBharathiMantena marked this pull request as draft May 8, 2025 06:51
@SwarnaBharathiMantena SwarnaBharathiMantena force-pushed the swarnabm/gke_node_consumption branch 2 times, most recently from e0640bc to f351dc8 Compare May 8, 2025 08:06
@ighosh98

ighosh98 commented May 8, 2025

Copy link
Copy Markdown
Contributor

I only see A3U blueprints. Are there any other machine types we should be supporting?

@ighosh98 ighosh98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please add the nccl-installer in all the modules and blueprints that are created
  • Remove on-demand blueprints
  • Add remaining integration tests.

Comment thread examples/gke-consumption-options/dws-calendar/README.md Outdated
Comment thread examples/gke-consumption-options/dws-calendar/README.md
Comment thread examples/gke-consumption-options/dws-flex-start-queued-provisioning/README.md Outdated
Comment thread examples/gke-consumption-options/on-demand/README.md Outdated
Comment thread examples/gke-consumption-options/spot/gke-a3-ultragpu.yaml Outdated
@annuay-google

Copy link
Copy Markdown
Contributor

Remove on-demand and spot blueprints till we are able to test these out.

Remove integration tests until we receive the allowlisting.

@annuay-google

Copy link
Copy Markdown
Contributor

Changes LGTM high level

@SwarnaBharathiMantena

Copy link
Copy Markdown
Contributor Author
  • Please add the nccl-installer in all the modules and blueprints that are created
  • Remove on-demand blueprints
  • Add remaining integration tests.

Will create a separate PR for integration tests.

@SwarnaBharathiMantena SwarnaBharathiMantena force-pushed the swarnabm/gke_node_consumption branch from d4bff50 to 64a7b78 Compare May 8, 2025 11:04
Comment thread examples/gke-consumption-options/dws-calendar/README.md
ighosh98
ighosh98 previously approved these changes May 8, 2025
@SwarnaBharathiMantena SwarnaBharathiMantena force-pushed the swarnabm/gke_node_consumption branch from af741bd to 47b09f5 Compare May 8, 2025 12:49
@SwarnaBharathiMantena SwarnaBharathiMantena marked this pull request as ready for review May 8, 2025 12:53
@ighosh98 ighosh98 merged commit c08f832 into GoogleCloudPlatform:develop May 8, 2025
14 of 66 checks passed
@SwarnaBharathiMantena SwarnaBharathiMantena added release-key-new-features Added to release notes under the "Key New Features" heading. and removed release-key-new-features Added to release notes under the "Key New Features" heading. labels May 9, 2025
@SwarnaBharathiMantena SwarnaBharathiMantena changed the title GKE consumption option examples GKE DWS Flex Start consumption option examples May 9, 2025
@SwarnaBharathiMantena

Copy link
Copy Markdown
Contributor Author

Updated the title upon a request to remove DWS Calendar at this time. #4090

@SwarnaBharathiMantena SwarnaBharathiMantena deleted the swarnabm/gke_node_consumption branch May 14, 2025 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants