Make login nodes deployable independently of "controller"#3958
Merged
Conversation
aba2ad1 to
edfc509
Compare
rohitramu
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: - allow to provision login group independently of "controller monolith"
Changes:
community/modules/internal/slurm-gcp/loginmodule;config.yaml;slurm_filesmodules;"${bucket}/login_group_configs/${name}.yaml"config file for login nodes;slurm_login_groupfor VMs to self identify;Breaking change - requires recreation of login nodes template and instances
NOTE: This PR could have been made into non-breaking change by:
internal/nodesetmodule, butfor_eachresource creation withincontrollermodule - doesn't break down monolith and makes it harder to reuse in other products;slurm_login_groupmetadata, but rely on VM name parsing - less clean, require moderate amount of refactoring of python-code.