Skip to content

Move from auth/munge to auth/slurm#3955

Merged
harshthakkar01 merged 3 commits into
GoogleCloudPlatform:developfrom
harshthakkar01:slurmauth
Apr 24, 2025
Merged

Move from auth/munge to auth/slurm#3955
harshthakkar01 merged 3 commits into
GoogleCloudPlatform:developfrom
harshthakkar01:slurmauth

Conversation

@harshthakkar01

@harshthakkar01 harshthakkar01 commented Apr 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This reverts #3805, we already updated cred-expire for long-prolog-slurm.conf.tpl #3801
This also adds a switch in controller module to controller authentication between munge and slurm.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@harshthakkar01 harshthakkar01 requested review from a team and samskillman as code owners April 16, 2025 22:16
@harshthakkar01 harshthakkar01 added release-chore To not include into release notes release-key-new-features Added to release notes under the "Key New Features" heading. and removed release-chore To not include into release notes labels Apr 16, 2025
@harshthakkar01 harshthakkar01 force-pushed the slurmauth branch 2 times, most recently from 94334d1 to a750c69 Compare April 21, 2025 21:59
@harshthakkar01

harshthakkar01 commented Apr 23, 2025

Copy link
Copy Markdown
Contributor Author

/gcbrun

@harshthakkar01 harshthakkar01 force-pushed the slurmauth branch 2 times, most recently from 442eb49 to 94d2f3f Compare April 23, 2025 23:02
mr0re1
mr0re1 previously approved these changes Apr 23, 2025
View reviewed changes

@mr0re1 mr0re1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a lot of code duplication, it would be nice to reduce it. But I'm not blocking PR on this, at your discretion .

@mr0re1 mr0re1 assigned harshthakkar01 and unassigned mr0re1 Apr 23, 2025
@harshthakkar01 harshthakkar01 force-pushed the slurmauth branch 3 times, most recently from 1cf196b to 5d38fa8 Compare April 24, 2025 03:51
mr0re1
mr0re1 previously approved these changes Apr 24, 2025
View reviewed changes
@harshthakkar01 harshthakkar01 merged commit 0fd80d5 into GoogleCloudPlatform:develop Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mr0re1 mr0re1 mr0re1 approved these changes

@samskillman samskillman Awaiting requested review from samskillman

Assignees

@harshthakkar01 harshthakkar01

Labels

release-key-new-features Added to release notes under the "Key New Features" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@harshthakkar01 @mr0re1