Skip to content

Add dws flex and spot provisioning options to the A4 example#3945

Merged
abbas1902 merged 1 commit into
GoogleCloudPlatform:developfrom
abbas1902:flex_blueprints
May 1, 2025
Merged

Add dws flex and spot provisioning options to the A4 example#3945
abbas1902 merged 1 commit into
GoogleCloudPlatform:developfrom
abbas1902:flex_blueprints

Conversation

@abbas1902

@abbas1902 abbas1902 commented Apr 14, 2025

Copy link
Copy Markdown
Collaborator

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@abbas1902 abbas1902 added the release-improvements Added to release notes under the "Improvements" heading. label Apr 14, 2025
@abbas1902 abbas1902 marked this pull request as ready for review April 14, 2025 23:48
@abbas1902 abbas1902 requested review from a team and samskillman as code owners April 14, 2025 23:48
@abbas1902 abbas1902 requested a review from mr0re1 April 14, 2025 23:48
mr0re1
mr0re1 previously approved these changes Apr 21, 2025
View reviewed changes
@mr0re1 mr0re1 assigned abbas1902 and unassigned mr0re1 Apr 21, 2025
@abbas1902 abbas1902 force-pushed the flex_blueprints branch 2 times, most recently from 2bdd430 to 440d331 Compare April 22, 2025 23:00
@abbas1902 abbas1902 changed the title Add dws flex and calendar mode A3U and A4 examples Add dws flex and calendar mode A4 example Apr 22, 2025
@abbas1902 abbas1902 force-pushed the flex_blueprints branch 3 times, most recently from e6bfa48 to b742b2a Compare April 23, 2025 23:01
@abbas1902 abbas1902 changed the title Add dws flex and calendar mode A4 example Add dws flex and spot provisioning options to the A4 example Apr 23, 2025
@abbas1902 abbas1902 assigned mr0re1 and unassigned abbas1902 Apr 23, 2025
mr0re1
mr0re1 previously approved these changes Apr 23, 2025
View reviewed changes
@mr0re1 mr0re1 assigned abbas1902 and unassigned mr0re1 Apr 23, 2025
@abbas1902 abbas1902 force-pushed the flex_blueprints branch 3 times, most recently from 2c63fc8 to 3fc5dd5 Compare April 25, 2025 22:51
mr0re1
mr0re1 reviewed Apr 25, 2025
View reviewed changes
Comment thread community/modules/compute/schedmd-slurm-gcp-v6-partition/variables.tf
mr0re1
mr0re1 reviewed Apr 25, 2025
View reviewed changes
Comment thread community/modules/compute/schedmd-slurm-gcp-v6-partition/main.tf Outdated
mr0re1
mr0re1 previously approved these changes Apr 25, 2025
View reviewed changes
mr0re1
mr0re1 previously approved these changes Apr 25, 2025
View reviewed changes
samskillman
samskillman reviewed Apr 29, 2025
View reviewed changes
Comment thread examples/machine-learning/a4-highgpu-8g/README.md Outdated
Comment thread community/modules/compute/schedmd-slurm-gcp-v6-partition/main.tf
Comment thread community/modules/compute/schedmd-slurm-gcp-v6-partition/variables.tf
Comment thread examples/machine-learning/a4-highgpu-8g/a4high-slurm-deployment.yaml
@abbas1902 abbas1902 enabled auto-merge May 1, 2025 17:57
@abbas1902 abbas1902 merged commit 3741b17 into GoogleCloudPlatform:develop May 1, 2025
12 of 64 checks passed
@abbas1902 abbas1902 deleted the flex_blueprints branch May 2, 2025 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samskillman samskillman samskillman left review comments

@mr0re1 mr0re1 mr0re1 approved these changes

Assignees

@abbas1902 abbas1902

Labels

release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@abbas1902 @mr0re1 @samskillman