Skip to content

Add MIG based DWS Flex support#3903

Merged
abbas1902 merged 4 commits into
GoogleCloudPlatform:developfrom
abbas1902:flex-branch
Apr 10, 2025
Merged

Add MIG based DWS Flex support#3903
abbas1902 merged 4 commits into
GoogleCloudPlatform:developfrom
abbas1902:flex-branch

Conversation

@abbas1902

@abbas1902 abbas1902 commented Apr 9, 2025

Copy link
Copy Markdown
Collaborator

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@abbas1902 abbas1902 added the release-improvements Added to release notes under the "Improvements" heading. label Apr 9, 2025
@abbas1902 abbas1902 marked this pull request as ready for review April 9, 2025 18:24
@abbas1902 abbas1902 requested review from a team and samskillman as code owners April 9, 2025 18:24
@abbas1902 abbas1902 requested a review from mr0re1 April 9, 2025 18:32
@abbas1902 abbas1902 force-pushed the flex-branch branch 2 times, most recently from ad4bddc to 82d9f8d Compare April 9, 2025 20:03
@abbas1902 abbas1902 added the do-not-merge Block merging of this PR label Apr 9, 2025
@abbas1902 abbas1902 force-pushed the flex-branch branch 4 times, most recently from a77e3ab to 69a6d22 Compare April 10, 2025 21:36
@abbas1902 abbas1902 removed the do-not-merge Block merging of this PR label Apr 10, 2025
mr0re1
mr0re1 reviewed Apr 10, 2025
View reviewed changes
Comment thread community/modules/compute/schedmd-slurm-gcp-v6-nodeset/variables.tf
mr0re1
mr0re1 previously approved these changes Apr 10, 2025
View reviewed changes
@mr0re1 mr0re1 assigned abbas1902 and unassigned mr0re1 Apr 10, 2025
@abbas1902 abbas1902 merged commit 93a87c4 into GoogleCloudPlatform:develop Apr 10, 2025
@abbas1902 abbas1902 deleted the flex-branch branch April 10, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mr0re1 mr0re1 mr0re1 approved these changes

@samskillman samskillman Awaiting requested review from samskillman

Assignees

@abbas1902 abbas1902

Labels

release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abbas1902 @mr0re1