Skip to content

Update imex and nvidia DRA Driver configurations#3902

Merged
ighosh98 merged 3 commits into
GoogleCloudPlatform:developfrom
ighosh98:develop
Apr 9, 2025
Merged

Update imex and nvidia DRA Driver configurations#3902
ighosh98 merged 3 commits into
GoogleCloudPlatform:developfrom
ighosh98:develop

Conversation

@ighosh98

@ighosh98 ighosh98 commented Apr 9, 2025

Copy link
Copy Markdown
Contributor

Submission Checklist

  • Updated IMEX and nvidia DRA Driver configurations. Primarily fixes indentations and updates driver definition.
  • Changing indentation for gke manifests leads to change in behavior. This in turn impacts gke cluster spin up. Hence disabling lint checks for this folder.

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

ighosh98 added 2 commits April 9, 2025 18:19
Changing indentation for gke manifests leads to change in behavior. This in turn impacts gke cluster spin up
@ighosh98 ighosh98 requested review from a team and samskillman as code owners April 9, 2025 12:53
Fix indentation issues and update configuration
@ighosh98 ighosh98 added the release-bugfix Added to release notes under the "Bug fixes" heading. label Apr 9, 2025
@ighosh98 ighosh98 enabled auto-merge April 9, 2025 12:57

@parulbajaj01 parulbajaj01 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ighosh98 ighosh98 merged commit f2ba9db into GoogleCloudPlatform:develop Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-bugfix Added to release notes under the "Bug fixes" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants