Update filestore timeout config based on high capacity tier#3900
Conversation
|
/gcbrun |
tpdownes
left a comment
There was a problem hiding this comment.
Please do not add legacy tiers to the error message. We should be actively steering customers away from HIGH_SCALE_SSD. The gap is intentional. It allows older customers to continue using HIGH_SCALE_SSD without modification but new blueprints to be guided to current recommended values.
https://cloud.google.com/filestore/docs/service-tiers#legacy-tiers
annuay-google
left a comment
There was a problem hiding this comment.
Mostly LGTM, please look at the comment
It would probably help to add a comment that the error message intentionally does not list legacy tiers even though they pass the validation logic. I wrote this code and it probably would have helped you. :) |
tpdownes
left a comment
There was a problem hiding this comment.
Approving on assumption that you'll accept my minimal change to the README.
I think we may eventually want to expose these settings as var.timeouts but, for now, this is an improvement that helps.
Timeout config for filestore provisioning, require an update based on newly supported tiers definition.
Update README with supported filestore resource tiers.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.