Skip to content

[GKE] Add support to enable DNS based endpoint config#3884

Merged
ighosh98 merged 5 commits into
GoogleCloudPlatform:developfrom
mohitchaurasia91:support-gke-dns-endpoint-config
Apr 7, 2025
Merged

[GKE] Add support to enable DNS based endpoint config#3884
ighosh98 merged 5 commits into
GoogleCloudPlatform:developfrom
mohitchaurasia91:support-gke-dns-endpoint-config

Conversation

@mohitchaurasia91

@mohitchaurasia91 mohitchaurasia91 commented Apr 4, 2025

Copy link
Copy Markdown
Contributor

Feature request to add support for DNS based endpoint config (refer open issue #3720)

References:

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@mohitchaurasia91 mohitchaurasia91 added the release-improvements Added to release notes under the "Improvements" heading. label Apr 4, 2025
@mohitchaurasia91 mohitchaurasia91 self-assigned this Apr 4, 2025
@mohitchaurasia91 mohitchaurasia91 marked this pull request as ready for review April 5, 2025 04:45
@mohitchaurasia91 mohitchaurasia91 requested review from a team and samskillman as code owners April 5, 2025 04:45
ighosh98
ighosh98 previously approved these changes Apr 5, 2025

@ighosh98 ighosh98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #3720

@ighosh98 ighosh98 enabled auto-merge April 5, 2025 05:21
@ighosh98

ighosh98 commented Apr 7, 2025

Copy link
Copy Markdown
Contributor

To be merged after #3888

@mohitchaurasia91

Copy link
Copy Markdown
Contributor Author

/gcbrun

@ighosh98 ighosh98 merged commit 07a12fb into GoogleCloudPlatform:develop Apr 7, 2025
@mohitchaurasia91 mohitchaurasia91 deleted the support-gke-dns-endpoint-config branch April 7, 2025 08:43
@mohitchaurasia91 mohitchaurasia91 added release-module-improvements Added to release notes under the "Module Improvements" heading. and removed release-improvements Added to release notes under the "Improvements" heading. labels Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-module-improvements Added to release notes under the "Module Improvements" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants