Skip to content

Add comment description for variables in a4 blueprint#3880

Merged
ighosh98 merged 2 commits into
GoogleCloudPlatform:developfrom
parulbajaj01:parul/gke-a4-fix
Apr 2, 2025
Merged

Add comment description for variables in a4 blueprint#3880
ighosh98 merged 2 commits into
GoogleCloudPlatform:developfrom
parulbajaj01:parul/gke-a4-fix

Conversation

@parulbajaj01

@parulbajaj01 parulbajaj01 commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@parulbajaj01 parulbajaj01 added the release-improvements Added to release notes under the "Improvements" heading. label Apr 2, 2025
@parulbajaj01 parulbajaj01 requested review from a team and samskillman as code owners April 2, 2025 14:22
SwarnaBharathiMantena
SwarnaBharathiMantena approved these changes Apr 2, 2025
View reviewed changes

@SwarnaBharathiMantena SwarnaBharathiMantena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ighosh98 ighosh98 merged commit ee66c9a into GoogleCloudPlatform:develop Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SwarnaBharathiMantena SwarnaBharathiMantena SwarnaBharathiMantena approved these changes

@samskillman samskillman Awaiting requested review from samskillman

Assignees

No one assigned

Labels

release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@parulbajaj01 @SwarnaBharathiMantena @ighosh98