Skip to content

Add disk size vars for A4#3872

Merged
ighosh98 merged 3 commits into
GoogleCloudPlatform:developfrom
parulbajaj01:parul/gke-a4-fix
Apr 2, 2025
Merged

Add disk size vars for A4#3872
ighosh98 merged 3 commits into
GoogleCloudPlatform:developfrom
parulbajaj01:parul/gke-a4-fix

Conversation

@parulbajaj01

Copy link
Copy Markdown
Contributor

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@parulbajaj01 parulbajaj01 added the release-improvements Added to release notes under the "Improvements" heading. label Apr 1, 2025
@parulbajaj01 parulbajaj01 requested review from a team and samskillman as code owners April 1, 2025 15:41

@ighosh98 ighosh98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default values are already defined in both the blueprints. I don't think these changes are need.
Please add reasons why this change is required.

@parulbajaj01

Copy link
Copy Markdown
Contributor Author

Default values are already defined in both the blueprints. I don't think these changes are need. Please add reasons why this change is required.

It's needed because in the public docs we have mentioned that the user can replace these variables to match the specific values in the deployement.yaml file and since we are adding the disk size vars in the public docs they will be actually needed in the deployment file.

@ighosh98

ighosh98 commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

Default values are already defined in both the blueprints. I don't think these changes are need. Please add reasons why this change is required.

It's needed because in the public docs we have mentioned that the user can replace these variables to match the specific values in the deployement.yaml file and since we are adding the disk size vars in the public docs they will be actually needed in the deployment file.

Thanks. Could you share a link to the docs if they are public?

@parulbajaj01

Copy link
Copy Markdown
Contributor Author

Default values are already defined in both the blueprints. I don't think these changes are need. Please add reasons why this change is required.

It's needed because in the public docs we have mentioned that the user can replace these variables to match the specific values in the deployement.yaml file and since we are adding the disk size vars in the public docs they will be actually needed in the deployment file.

Thanks. Could you share a link to the docs if they are public?

https://cloud.google.com/ai-hypercomputer/docs/create/gke-ai-hypercompute#:~:text=In%20the%20examples/gke%2Da4%2Dhighgpu/gke%2Da4%2Dhighgpu%2Ddeployment.yaml%20file%2C%20replace%20the%20following%20variables%20in%20the%20terraform_backend_defaults%20and%20vars%20sections%20to%20match%20the%20specific%20values%20for%20your%20deployment%3A

Comment thread examples/gke-a4/gke-a4-deployment.yaml Outdated

@ighosh98 ighosh98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

general comment: we should come up with a consistent nomenclature/style. For instance adding #add this in every blueprint

@ighosh98 ighosh98 enabled auto-merge April 2, 2025 10:52
@ighosh98 ighosh98 merged commit a863422 into GoogleCloudPlatform:develop Apr 2, 2025
@SwarnaBharathiMantena

Copy link
Copy Markdown
Contributor

A comment above those variables describing what they are for can help, just like how the other variables have comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants