Add disk size vars for A4#3872
Conversation
ighosh98
left a comment
There was a problem hiding this comment.
Default values are already defined in both the blueprints. I don't think these changes are need.
Please add reasons why this change is required.
It's needed because in the public docs we have mentioned that the user can replace these variables to match the specific values in the deployement.yaml file and since we are adding the disk size vars in the public docs they will be actually needed in the deployment file. |
Thanks. Could you share a link to the docs if they are public? |
|
ighosh98
left a comment
There was a problem hiding this comment.
general comment: we should come up with a consistent nomenclature/style. For instance adding #add this in every blueprint
|
A comment above those variables describing what they are for can help, just like how the other variables have comments. |
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.