Skip to content

Add omnia deprecation warning and update A3U and A4 blueprints threads configurations#3837

Merged
ighosh98 merged 5 commits into
GoogleCloudPlatform:developfrom
ighosh98:develop
Mar 26, 2025
Merged

Add omnia deprecation warning and update A3U and A4 blueprints threads configurations#3837
ighosh98 merged 5 commits into
GoogleCloudPlatform:developfrom
ighosh98:develop

Conversation

@ighosh98

@ighosh98 ighosh98 commented Mar 25, 2025

Copy link
Copy Markdown
Contributor

Submission Checklist

https://github.com/GoogleCloudPlatform/cluster-toolkit/blob/develop/community/modules/scripts/omnia-install/README.md has no mention that this module is deprecated. However, it is marked as deprecated in https://github.com/GoogleCloudPlatform/cluster-toolkit/tree/develop/modules.

  • Add threads_per_core configuration to A3U and A4 blueprints to slurm blueprints.

This PR fixes the discrepancy.

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@ighosh98 ighosh98 requested a review from parulbajaj01 March 25, 2025 17:55
@ighosh98 ighosh98 requested review from a team and samskillman as code owners March 25, 2025 17:55
@ighosh98 ighosh98 added the release-deprecations Added to release notes under the "Deprecations" heading. label Mar 25, 2025
@ighosh98 ighosh98 enabled auto-merge March 25, 2025 17:57

@parulbajaj01 parulbajaj01 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ighosh98 ighosh98 merged commit 6844d1e into GoogleCloudPlatform:develop Mar 26, 2025
@ighosh98 ighosh98 changed the title Add omnia deprecation warning Add omnia deprecation warning and update A3U and A4 blueprints threads configurations Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-deprecations Added to release notes under the "Deprecations" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants