Skip to content

Support resource manager tags on instance template and attached disks#3829

Merged
annuay-google merged 2 commits into
GoogleCloudPlatform:developfrom
annuay-google:support-resource-manager-tags
Mar 25, 2025
Merged

Support resource manager tags on instance template and attached disks#3829
annuay-google merged 2 commits into
GoogleCloudPlatform:developfrom
annuay-google:support-resource-manager-tags

Conversation

@annuay-google

Copy link
Copy Markdown
Contributor

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@annuay-google annuay-google requested review from a team and samskillman as code owners March 24, 2025 05:52
@annuay-google annuay-google changed the title Support resource manager tags on Instance Template and attached disks Support resource manager tags on instance template and attached disks Mar 24, 2025
Comment thread community/modules/compute/schedmd-slurm-gcp-v6-nodeset/main.tf
mr0re1
mr0re1 previously approved these changes Mar 24, 2025
ankitkinra
ankitkinra previously approved these changes Mar 25, 2025
@annuay-google annuay-google force-pushed the support-resource-manager-tags branch from 1ae17d8 to 49564df Compare March 25, 2025 08:22
@annuay-google annuay-google added the release-key-new-features Added to release notes under the "Key New Features" heading. label Mar 25, 2025
@annuay-google annuay-google force-pushed the support-resource-manager-tags branch from f269b85 to f57fcc5 Compare March 25, 2025 09:06
@annuay-google annuay-google merged commit 7485dc8 into GoogleCloudPlatform:develop Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-key-new-features Added to release notes under the "Key New Features" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants