Skip to content

Support multiple nodepools creation in gke nodepool module#3826

Merged
SwarnaBharathiMantena merged 1 commit into
GoogleCloudPlatform:developfrom
SwarnaBharathiMantena:swarnabm/gke_multiple_node_pools
Mar 24, 2025
Merged

Support multiple nodepools creation in gke nodepool module#3826
SwarnaBharathiMantena merged 1 commit into
GoogleCloudPlatform:developfrom
SwarnaBharathiMantena:swarnabm/gke_multiple_node_pools

Conversation

@SwarnaBharathiMantena

Copy link
Copy Markdown
Contributor

GKE nodepool module update to create multiple identical nodepools.

  • num_node_pools parameters defines number of nodepools to spin up.
  • node_pool_names is a list of strings output that captures the names of the nodepools created.
  • The job template module is update to accept this list of strings output.
  • Examples which configure the nodeLabel in kueue configuration are also updated.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@SwarnaBharathiMantena SwarnaBharathiMantena added the release-module-improvements Added to release notes under the "Module Improvements" heading. label Mar 21, 2025
@SwarnaBharathiMantena SwarnaBharathiMantena changed the title Support multiple nodepools in gke nodepool module Support multiple nodepools creation in gke nodepool module Mar 21, 2025
ighosh98
ighosh98 previously approved these changes Mar 21, 2025

@ighosh98 ighosh98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Make sure all downstream dependencies are informed of this change.

cboneti
cboneti previously approved these changes Mar 21, 2025
@SwarnaBharathiMantena SwarnaBharathiMantena dismissed stale reviews from cboneti and ighosh98 via fbd4286 March 24, 2025 03:30
@SwarnaBharathiMantena SwarnaBharathiMantena force-pushed the swarnabm/gke_multiple_node_pools branch from fbd4286 to c64b5fa Compare March 24, 2025 04:04
@SwarnaBharathiMantena SwarnaBharathiMantena force-pushed the swarnabm/gke_multiple_node_pools branch from c64b5fa to fa3fb36 Compare March 24, 2025 05:50
@ighosh98 ighosh98 self-requested a review March 24, 2025 05:52
Comment thread modules/compute/gke-node-pool/variables.tf
@SwarnaBharathiMantena SwarnaBharathiMantena merged commit 52f29d1 into GoogleCloudPlatform:develop Mar 24, 2025
@SwarnaBharathiMantena SwarnaBharathiMantena deleted the swarnabm/gke_multiple_node_pools branch March 28, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-module-improvements Added to release notes under the "Module Improvements" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants