Skip to content

Rollback name injection change in job template#3821

Merged
ighosh98 merged 1 commit into
GoogleCloudPlatform:developfrom
ighosh98:develop
Mar 20, 2025
Merged

Rollback name injection change in job template#3821
ighosh98 merged 1 commit into
GoogleCloudPlatform:developfrom
ighosh98:develop

Conversation

@ighosh98

Copy link
Copy Markdown
Contributor

Rollback the change to job template metadata as it is causing test failures. Will update all the impacted tests first and then push the change again

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

Rollback the change as it is causing test failures. Will update all the impacted tests first and then push the change again
@ighosh98 ighosh98 requested review from a team and samskillman as code owners March 20, 2025 12:11
@ighosh98 ighosh98 added the release-bugfix Added to release notes under the "Bug fixes" heading. label Mar 20, 2025
@ighosh98 ighosh98 enabled auto-merge March 20, 2025 12:13

@parulbajaj01 parulbajaj01 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ighosh98 ighosh98 merged commit 0dda5e2 into GoogleCloudPlatform:develop Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-bugfix Added to release notes under the "Bug fixes" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants