Skip to content

Improve job template naming#3816

Merged
ighosh98 merged 2 commits into
GoogleCloudPlatform:developfrom
ighosh98:ml-gke
Mar 20, 2025
Merged

Improve job template naming#3816
ighosh98 merged 2 commits into
GoogleCloudPlatform:developfrom
ighosh98:ml-gke

Conversation

@ighosh98

@ighosh98 ighosh98 commented Mar 19, 2025

Copy link
Copy Markdown
Contributor

Submission Checklist

  • Make the variable name and template more user friendly.

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@ighosh98 ighosh98 requested a review from parulbajaj01 March 19, 2025 11:27
@ighosh98 ighosh98 requested review from a team and samskillman as code owners March 19, 2025 11:27
@ighosh98 ighosh98 added the release-improvements Added to release notes under the "Improvements" heading. label Mar 19, 2025
@ighosh98 ighosh98 enabled auto-merge March 20, 2025 06:49
parulbajaj01
parulbajaj01 approved these changes Mar 20, 2025
View reviewed changes

@parulbajaj01 parulbajaj01 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ighosh98 ighosh98 merged commit 00b3f11 into GoogleCloudPlatform:develop Mar 20, 2025
@harshthakkar01 harshthakkar01 mentioned this pull request Apr 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parulbajaj01 parulbajaj01 parulbajaj01 approved these changes

@samskillman samskillman Awaiting requested review from samskillman

Assignees

No one assigned

Labels

release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ighosh98 @parulbajaj01