Skip to content

add support for enablePrivateNode at nodepool level#3794

Merged
chengcongdu merged 2 commits into
GoogleCloudPlatform:developfrom
chengcongdu:develop
Mar 11, 2025
Merged

add support for enablePrivateNode at nodepool level#3794
chengcongdu merged 2 commits into
GoogleCloudPlatform:developfrom
chengcongdu:develop

Conversation

@chengcongdu

@chengcongdu chengcongdu commented Mar 11, 2025

Copy link
Copy Markdown
Member

the current nodepool module doesn't configure enablePrivateNodes in its network_config block.
The enablePrivateNode setting wasn't pass down to nodepool as well when nodepool module have any network_config added.

@chengcongdu chengcongdu requested review from a team and samskillman as code owners March 11, 2025 22:17
@chengcongdu chengcongdu added the release-module-improvements Added to release notes under the "Module Improvements" heading. label Mar 11, 2025
@chengcongdu chengcongdu enabled auto-merge March 11, 2025 22:39
@chengcongdu

chengcongdu commented Mar 11, 2025

Copy link
Copy Markdown
Member Author

tested with sample workload

Events:
  Type    Reason     Age    From                                   Message
  ----    ------     ----   ----                                   -------
  Normal  Scheduled  2m59s  gke.io/optimize-utilization-scheduler  Successfully assigned default/run-nvidia-smi-dd7a-0-p8jbw to gke-chdu-a3u-a3-ultragpu-8g-a3-ultrag-46a6b7e2-1n34
  Normal  Pulling    2m57s  kubelet                                Pulling image "nvidia/cuda:11.0.3-runtime-ubuntu20.04"
  Normal  Pulled     2m41s  kubelet                                Successfully pulled image "nvidia/cuda:11.0.3-runtime-ubuntu20.04" in 15.536s (15.536s including waiting). Image size: 1265138526 bytes.
  Normal  Created    2m41s  kubelet                                Created container: run-nvidia-smi-container
  Normal  Started    2m41s  kubelet                                Started container run-nvidia-smi-container
user@chdu:~/fork/hpc-toolkit$ k get po
NAME                          READY   STATUS      RESTARTS   AGE
run-nvidia-smi-dd7a-0-p8jbw   0/1     Completed   0          5m30s
run-nvidia-smi-dd7a-1-rx8qn   0/1     Completed   0          5m30s
user@chdu:~/fork/hpc-toolkit$

@chengcongdu chengcongdu merged commit 830375f into GoogleCloudPlatform:develop Mar 11, 2025
@harshthakkar01 harshthakkar01 mentioned this pull request Apr 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samskillman samskillman samskillman approved these changes

Assignees

No one assigned

Labels

release-module-improvements Added to release notes under the "Module Improvements" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chengcongdu @samskillman