Skip to content

Add nodeset name as a label to all nodeset instance templates#3787

Merged
annuay-google merged 1 commit into
GoogleCloudPlatform:developfrom
annuay-google:annuay/add-slurm-nodeset-label
Mar 12, 2025
Merged

Add nodeset name as a label to all nodeset instance templates#3787
annuay-google merged 1 commit into
GoogleCloudPlatform:developfrom
annuay-google:annuay/add-slurm-nodeset-label

Conversation

@annuay-google

Copy link
Copy Markdown
Contributor

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@annuay-google annuay-google requested a review from mr0re1 March 11, 2025 11:47
@annuay-google annuay-google requested review from a team and samskillman as code owners March 11, 2025 11:47
@annuay-google annuay-google added the release-module-improvements Added to release notes under the "Module Improvements" heading. label Mar 11, 2025
@annuay-google annuay-google changed the base branch from develop to main March 11, 2025 17:06
@annuay-google annuay-google changed the base branch from main to develop March 11, 2025 17:07
Comment thread community/modules/compute/schedmd-slurm-gcp-v6-nodeset/main.tf Outdated
mr0re1
mr0re1 previously approved these changes Mar 12, 2025
Comment thread community/modules/compute/schedmd-slurm-gcp-v6-nodeset/main.tf Outdated
Comment thread community/modules/compute/schedmd-slurm-gcp-v6-nodeset/main.tf Outdated
@annuay-google annuay-google force-pushed the annuay/add-slurm-nodeset-label branch from 3cee031 to 2248ba2 Compare March 12, 2025 01:13
@annuay-google annuay-google merged commit 4eba864 into GoogleCloudPlatform:develop Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-module-improvements Added to release notes under the "Module Improvements" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants