Skip to content

Add comment descriptions for a3U vars#3783

Merged
ighosh98 merged 7 commits into
GoogleCloudPlatform:developfrom
parulbajaj01:gke-a3u-fixes
Mar 17, 2025
Merged

Add comment descriptions for a3U vars#3783
ighosh98 merged 7 commits into
GoogleCloudPlatform:developfrom
parulbajaj01:gke-a3u-fixes

Conversation

@parulbajaj01

@parulbajaj01 parulbajaj01 commented Mar 10, 2025

Copy link
Copy Markdown
Contributor

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@parulbajaj01 parulbajaj01 requested review from a team and samskillman as code owners March 10, 2025 14:41
@parulbajaj01 parulbajaj01 added the release-improvements Added to release notes under the "Improvements" heading. label Mar 10, 2025
@ighosh98 ighosh98 changed the base branch from develop to a4x-develop March 10, 2025 15:24
@ighosh98 ighosh98 enabled auto-merge March 10, 2025 15:25
ighosh98
ighosh98 previously approved these changes Mar 10, 2025
View reviewed changes
@ighosh98 ighosh98 mentioned this pull request Mar 10, 2025
Closed
@ighosh98 ighosh98 changed the title Add comment descriptions for GKE A3U vars Add test blueprint for A4X Mar 10, 2025
@ighosh98 ighosh98 changed the base branch from a4x-develop to develop March 10, 2025 15:29
@ighosh98 ighosh98 dismissed their stale review March 10, 2025 15:29

The base branch was changed.

@ighosh98 ighosh98 changed the title Add test blueprint for A4X Add comment descriptions for a3U vars Mar 10, 2025
SwarnaBharathiMantena
SwarnaBharathiMantena reviewed Mar 11, 2025
View reviewed changes
Comment thread examples/gke-a3-ultragpu/gke-a3-ultragpu-deployment.yaml Outdated
ighosh98
ighosh98 suggested changes Mar 11, 2025
View reviewed changes
Comment thread examples/gke-a3-ultragpu/gke-a3-ultragpu-deployment.yaml
ighosh98
ighosh98 suggested changes Mar 12, 2025
View reviewed changes
Comment thread examples/gke-a3-ultragpu/gke-a3-ultragpu-deployment.yaml
ighosh98
ighosh98 approved these changes Mar 17, 2025
View reviewed changes

@ighosh98 ighosh98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread examples/gke-a3-ultragpu/gke-a3-ultragpu-deployment.yaml
@ighosh98 ighosh98 merged commit 58026cc into GoogleCloudPlatform:develop Mar 17, 2025
@harshthakkar01 harshthakkar01 mentioned this pull request Apr 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@annuay-google annuay-google Awaiting requested review from annuay-google

@samskillman samskillman Awaiting requested review from samskillman

@SwarnaBharathiMantena SwarnaBharathiMantena Awaiting requested review from SwarnaBharathiMantena

1 more reviewer

@ighosh98 ighosh98 ighosh98 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@parulbajaj01 @ighosh98 @SwarnaBharathiMantena