Cloud DNS config addition to GKE Cluster module#3752
Merged
SwarnaBharathiMantena merged 1 commit intoMar 5, 2025
Conversation
97fe6fb to
16e0e35
Compare
annuay-google
approved these changes
Mar 5, 2025
16e0e35 to
e57ac25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Cloud DNS is exposed as a DNS provider option in the gke-cluster module.
Why?
The Cloud DNS provider replaces the default kube-dns in-cluster provider with Google's managed Cloud DNS service, and is often preferable for larger-node-count clusters.
Testing
Manually tested provisioning/updates, make tests passed, pre-commit hooks ran fine, and CLA should be on file.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.