Skip to content

GCS update to GKE A4 High blueprint#3749

Merged
SwarnaBharathiMantena merged 1 commit into
GoogleCloudPlatform:developfrom
SwarnaBharathiMantena:swarnabm/gke-a4-high-gcs-update
Mar 10, 2025
Merged

GCS update to GKE A4 High blueprint#3749
SwarnaBharathiMantena merged 1 commit into
GoogleCloudPlatform:developfrom
SwarnaBharathiMantena:swarnabm/gke-a4-high-gcs-update

Conversation

@SwarnaBharathiMantena

@SwarnaBharathiMantena SwarnaBharathiMantena commented Mar 3, 2025

Copy link
Copy Markdown
Contributor

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@SwarnaBharathiMantena SwarnaBharathiMantena added the release-improvements Added to release notes under the "Improvements" heading. label Mar 3, 2025
samskillman
samskillman previously approved these changes Mar 4, 2025
View reviewed changes
@SwarnaBharathiMantena SwarnaBharathiMantena force-pushed the swarnabm/gke-a4-high-gcs-update branch 2 times, most recently from eadf083 to c4418a0 Compare March 4, 2025 15:43
@SwarnaBharathiMantena SwarnaBharathiMantena force-pushed the swarnabm/gke-a4-high-gcs-update branch from 3b06888 to f313382 Compare March 4, 2025 16:49
@SwarnaBharathiMantena SwarnaBharathiMantena force-pushed the swarnabm/gke-a4-high-gcs-update branch from f313382 to 92b6c04 Compare March 4, 2025 18:55
samskillman
samskillman previously approved these changes Mar 4, 2025
View reviewed changes
ighosh98
ighosh98 previously approved these changes Mar 4, 2025
View reviewed changes
Comment thread examples/gke-a4-highgpu/gke-a4-highgpu-deployment.yaml
Comment thread examples/gke-a4-highgpu/gke-a4-highgpu.yaml
@SwarnaBharathiMantena SwarnaBharathiMantena force-pushed the swarnabm/gke-a4-high-gcs-update branch from af5fbb3 to b8114a9 Compare March 10, 2025 07:19
@SwarnaBharathiMantena SwarnaBharathiMantena force-pushed the swarnabm/gke-a4-high-gcs-update branch from 5c16582 to 8e654bf Compare March 10, 2025 07:24
@SwarnaBharathiMantena

SwarnaBharathiMantena commented Mar 10, 2025

Copy link
Copy Markdown
Contributor Author

gke-a4-highgpu test successful: https://pantheon.corp.google.com/cloud-build/builds/024019ed-579b-4547-a1bc-0bcb600d65f2?project=hpc-toolkit-dev&e=13803378&mods=monitoring_api_prod&invt=AbrpDw&inv=1

@ighosh98 ighosh98 self-requested a review March 10, 2025 09:06
@SwarnaBharathiMantena SwarnaBharathiMantena merged commit 17964f3 into GoogleCloudPlatform:develop Mar 10, 2025
@SwarnaBharathiMantena SwarnaBharathiMantena deleted the swarnabm/gke-a4-high-gcs-update branch March 28, 2025 07:08
@harshthakkar01 harshthakkar01 mentioned this pull request Apr 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samskillman samskillman samskillman left review comments

@annuay-google annuay-google Awaiting requested review from annuay-google

@chengcongdu chengcongdu Awaiting requested review from chengcongdu

+1 more reviewer

@ighosh98 ighosh98 ighosh98 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@samskillman samskillman

Labels

release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SwarnaBharathiMantena @samskillman @ighosh98