Skip to content

Add NeMo and HPL Slurm GCS System Benchmarks with Ramble#3726

Merged
samskillman merged 4 commits into
GoogleCloudPlatform:developfrom
samskillman:feat/a3u-slurm-gcs-system-benchmarks
Mar 6, 2025
Merged

Add NeMo and HPL Slurm GCS System Benchmarks with Ramble#3726
samskillman merged 4 commits into
GoogleCloudPlatform:developfrom
samskillman:feat/a3u-slurm-gcs-system-benchmarks

Conversation

@samskillman

@samskillman samskillman commented Feb 26, 2025

Copy link
Copy Markdown
Collaborator

Add system benchmarks for a3u-slurm-ubuntu-gcs

  • Moved nccl-tests to system_benchmarks
  • Add NeMo and HPL
  • Adopts persistenced approach

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@samskillman samskillman added the release-improvements Added to release notes under the "Improvements" heading. label Feb 26, 2025
@samskillman samskillman requested review from a team, chengcongdu and yuryu as code owners February 26, 2025 17:23
@gemini-code-assist

gemini-code-assist Bot commented Feb 26, 2025

Copy link
Copy Markdown
Contributor

Important

The terms of service for this installation has not been accepted. Please ask the Organization owners to visit the Gemini Code Assist Admin Console to sign it.

@samskillman samskillman force-pushed the feat/a3u-slurm-gcs-system-benchmarks branch from f81e91b to 7aa93dc Compare February 26, 2025 17:23
@samskillman samskillman force-pushed the feat/a3u-slurm-gcs-system-benchmarks branch from 7aa93dc to 4bc17ff Compare February 26, 2025 19:41
harshthakkar01
harshthakkar01 previously approved these changes Feb 27, 2025
View reviewed changes
@samskillman samskillman force-pushed the feat/a3u-slurm-gcs-system-benchmarks branch from 4bc17ff to 078a963 Compare March 4, 2025 03:43
@samskillman samskillman force-pushed the feat/a3u-slurm-gcs-system-benchmarks branch from 078a963 to dab044e Compare March 5, 2025 19:51
@samskillman samskillman force-pushed the feat/a3u-slurm-gcs-system-benchmarks branch from dab044e to dd1b761 Compare March 6, 2025 18:47
@samskillman samskillman merged commit 27c4780 into GoogleCloudPlatform:develop Mar 6, 2025
@samskillman samskillman deleted the feat/a3u-slurm-gcs-system-benchmarks branch March 6, 2025 19:06
@harshthakkar01 harshthakkar01 mentioned this pull request Apr 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harshthakkar01 harshthakkar01 harshthakkar01 approved these changes

@chengcongdu chengcongdu Awaiting requested review from chengcongdu

@yuryu yuryu Awaiting requested review from yuryu

Assignees

@harshthakkar01 harshthakkar01

Labels

release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samskillman @harshthakkar01