Skip to content

Remove autoscaling max nodes from A3H and A3M tests#3696

Merged
parulbajaj01 merged 1 commit into
GoogleCloudPlatform:developfrom
parulbajaj01:gke-network-config
Feb 21, 2025
Merged

Remove autoscaling max nodes from A3H and A3M tests#3696
parulbajaj01 merged 1 commit into
GoogleCloudPlatform:developfrom
parulbajaj01:gke-network-config

Conversation

@parulbajaj01

Copy link
Copy Markdown
Contributor

Removed Autoscaling max nodes from tests in A3High and A3Mega, as static node count was added to them earlier.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@parulbajaj01 parulbajaj01 added the release-improvements Added to release notes under the "Improvements" heading. label Feb 21, 2025

@annuay-google annuay-google left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test that both these tests run correctly from your workstation. Apart from that, LGTM

@annuay-google annuay-google left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parulbajaj01 parulbajaj01 merged commit ec60a41 into GoogleCloudPlatform:develop Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants