Skip to content

Advanced network configuration support on notebook instance community module#3671

Merged
ighosh98 merged 9 commits into
GoogleCloudPlatform:developfrom
caetano-colin:advanced-network-config
Mar 26, 2025
Merged

Advanced network configuration support on notebook instance community module#3671
ighosh98 merged 9 commits into
GoogleCloudPlatform:developfrom
caetano-colin:advanced-network-config

Conversation

@caetano-colin

@caetano-colin caetano-colin commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

PR originated from Issue #3645

This PR will make the notebook module support more advanced network configuration, for example:

  • user-defined subnetwork
  • user-defined network interface card
  • support for shared-vpc usage
  • specify custom external ip address

@caetano-colin caetano-colin changed the title feat: advanced network configuration support on notebook instance Advanced network configuration support on notebook instance community module Feb 13, 2025
@caetano-colin caetano-colin marked this pull request as ready for review February 13, 2025 17:14
@ighosh98 ighosh98 requested a review from tpdownes February 17, 2025 10:17

@apeabody apeabody left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @caetano-colin!

Comment thread community/modules/compute/notebook/README.md Outdated
Comment thread community/modules/compute/notebook/main.tf Outdated
caetano-colin and others added 2 commits February 27, 2025 13:48
Co-authored-by: Andrew Peabody <andrewpeabody@google.com>
Co-authored-by: Andrew Peabody <andrewpeabody@google.com>
ighosh98
ighosh98 previously approved these changes Mar 25, 2025

@ighosh98 ighosh98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ighosh98

Copy link
Copy Markdown
Contributor

/gcbrun

@ighosh98 ighosh98 added the release-improvements Added to release notes under the "Improvements" heading. label Mar 25, 2025
@ighosh98

Copy link
Copy Markdown
Contributor

@caetano-colin could you please fix the pre-commit errors coming from the README file?

@caetano-colin

Copy link
Copy Markdown
Contributor Author

@caetano-colin could you please fix the pre-commit errors coming from the README file?

Sure!

@ighosh98 ighosh98 self-requested a review March 25, 2025 11:56
@ighosh98 ighosh98 requested review from tpdownes and removed request for tpdownes March 25, 2025 11:58
@cboneti cboneti self-requested a review March 25, 2025 13:22
@parulbajaj01 parulbajaj01 self-requested a review March 25, 2025 13:37

@parulbajaj01 parulbajaj01 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ighosh98

Copy link
Copy Markdown
Contributor

/gcbrun

@ighosh98 ighosh98 enabled auto-merge March 26, 2025 03:56
@ighosh98

Copy link
Copy Markdown
Contributor

/gcbrun

@ighosh98 ighosh98 merged commit bc9cdfc into GoogleCloudPlatform:develop Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants