Skip to content

Add controller save state disk#3661

Merged
alyssa-sm merged 1 commit into
GoogleCloudPlatform:developfrom
alyssa-sm:disk-save-state
Feb 20, 2025
Merged

Add controller save state disk#3661
alyssa-sm merged 1 commit into
GoogleCloudPlatform:developfrom
alyssa-sm:disk-save-state

Conversation

@alyssa-sm

@alyssa-sm alyssa-sm commented Feb 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR implements a state save disk for the controller. With this implementation, slurm information saved on the controller will persist even if the controller were to be destroyed.

@alyssa-sm alyssa-sm self-assigned this Feb 10, 2025
@alyssa-sm alyssa-sm marked this pull request as ready for review February 11, 2025 17:50
@alyssa-sm alyssa-sm requested a review from mr0re1 February 11, 2025 17:50
@alyssa-sm alyssa-sm added the release-key-new-features Added to release notes under the "Key New Features" heading. label Feb 11, 2025
@alyssa-sm alyssa-sm assigned mr0re1 and unassigned alyssa-sm Feb 11, 2025
mr0re1
mr0re1 reviewed Feb 11, 2025
View reviewed changes
Comment thread community/modules/scheduler/schedmd-slurm-gcp-v6-controller/controller.tf Outdated
mr0re1
mr0re1 reviewed Feb 11, 2025
View reviewed changes
Comment thread community/modules/scheduler/schedmd-slurm-gcp-v6-controller/controller.tf Outdated
mr0re1
mr0re1 reviewed Feb 11, 2025
View reviewed changes
Comment thread community/modules/scheduler/schedmd-slurm-gcp-v6-controller/variables.tf Outdated
@mr0re1 mr0re1 assigned alyssa-sm and unassigned mr0re1 Feb 12, 2025
@alyssa-sm alyssa-sm force-pushed the disk-save-state branch 5 times, most recently from 362adae to 7e8e622 Compare February 14, 2025 10:35
@alyssa-sm alyssa-sm requested a review from mr0re1 February 14, 2025 10:37
@alyssa-sm alyssa-sm assigned mr0re1 and unassigned alyssa-sm Feb 14, 2025
mr0re1
mr0re1 reviewed Feb 14, 2025
View reviewed changes
Comment thread community/modules/internal/slurm-gcp/instance_template/variables.tf Outdated
@alyssa-sm alyssa-sm requested a review from mr0re1 February 19, 2025 00:17
@alyssa-sm alyssa-sm assigned mr0re1 and unassigned alyssa-sm Feb 19, 2025
mr0re1
mr0re1 reviewed Feb 19, 2025
View reviewed changes
Comment thread community/modules/internal/slurm-gcp/internal_instance_template/main.tf Outdated
mr0re1
mr0re1 reviewed Feb 19, 2025
View reviewed changes
Comment thread community/modules/scheduler/schedmd-slurm-gcp-v6-controller/controller.tf Outdated
mr0re1
mr0re1 reviewed Feb 19, 2025
View reviewed changes
Comment thread community/modules/scheduler/schedmd-slurm-gcp-v6-controller/slurm_files.tf Outdated
mr0re1
mr0re1 reviewed Feb 19, 2025
View reviewed changes
Comment thread community/modules/scheduler/schedmd-slurm-gcp-v6-controller/variables.tf Outdated
@mr0re1 mr0re1 assigned alyssa-sm and unassigned mr0re1 Feb 19, 2025
@alyssa-sm alyssa-sm requested a review from mr0re1 February 19, 2025 19:54
@alyssa-sm alyssa-sm assigned mr0re1 and unassigned alyssa-sm Feb 19, 2025
mr0re1
mr0re1 reviewed Feb 20, 2025
View reviewed changes
Comment thread community/modules/scheduler/schedmd-slurm-gcp-v6-controller/controller.tf
@alyssa-sm alyssa-sm merged commit d4b5e9b into GoogleCloudPlatform:develop Feb 20, 2025
@alyssa-sm alyssa-sm deleted the disk-save-state branch February 20, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mr0re1 mr0re1 mr0re1 approved these changes

@chengcongdu chengcongdu Awaiting requested review from chengcongdu

@douglasjacobsen douglasjacobsen Awaiting requested review from douglasjacobsen

@samskillman samskillman Awaiting requested review from samskillman

@yuryu yuryu Awaiting requested review from yuryu

Assignees

@mr0re1 mr0re1

Labels

release-key-new-features Added to release notes under the "Key New Features" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alyssa-sm @mr0re1 @abbas1902