Skip to content

Support DWS Flex on GKE#3636

Merged
SwarnaBharathiMantena merged 3 commits into
GoogleCloudPlatform:developfrom
SwarnaBharathiMantena:swarnabm/gke-dws-flex-start
Feb 4, 2025
Merged

Support DWS Flex on GKE#3636
SwarnaBharathiMantena merged 3 commits into
GoogleCloudPlatform:developfrom
SwarnaBharathiMantena:swarnabm/gke-dws-flex-start

Conversation

@SwarnaBharathiMantena

Copy link
Copy Markdown
Contributor

Add gke dws flex start example with a README, and an integration test.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@SwarnaBharathiMantena SwarnaBharathiMantena added the release-key-new-features Added to release notes under the "Key New Features" heading. label Feb 4, 2025
Comment thread tools/cloud-build/daily-tests/builds/gke-dws-flex-start.yaml Outdated
Comment thread examples/gke-dws-flex-start/README.md
Comment thread examples/gke-dws-flex-start/gke-dws-flex-start.yaml
Comment thread examples/gke-dws-flex-start/sample-job.yaml

@annuay-google annuay-google left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reference the older PR as a comment- helps preserve the review history

@SwarnaBharathiMantena

Copy link
Copy Markdown
Contributor Author

Closed this previous PR due to inconsistency: #3632
Added as a reference for the comments.

@SwarnaBharathiMantena SwarnaBharathiMantena force-pushed the swarnabm/gke-dws-flex-start branch from 7bd6061 to 8a4763b Compare February 4, 2025 08:30
@annuay-google annuay-google changed the title add gke dws flex start example and integration test Support DWS Flex on GKE Feb 4, 2025
Comment thread examples/gke-dws-flex-start/README.md Outdated
@SwarnaBharathiMantena SwarnaBharathiMantena force-pushed the swarnabm/gke-dws-flex-start branch from 42d460a to 870d8fe Compare February 4, 2025 10:03

@annuay-google annuay-google left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SwarnaBharathiMantena SwarnaBharathiMantena merged commit a5b5fec into GoogleCloudPlatform:develop Feb 4, 2025
@SwarnaBharathiMantena SwarnaBharathiMantena deleted the swarnabm/gke-dws-flex-start branch March 28, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-key-new-features Added to release notes under the "Key New Features" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants