Add variable for k8s service account and remove hardcoded value#3634
Merged
parulbajaj01 merged 1 commit intoFeb 4, 2025
Merged
Conversation
annuay-google
requested changes
Feb 3, 2025
annuay-google
left a comment
Contributor
There was a problem hiding this comment.
Please update job-template to use the service account as well
Contributor
Author
|
Updated the changes |
afaef9f to
cb64687
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made k8s service account name configurable by user. Removed the hardcoded value and passed it through variable.
To test the changes:
Deployed gke-a3-ultragpu and ran the following command to verify -
kubectl get serviceaccountsSubmission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.