Skip to content

Fixed naming for deployment name in test to fit in size limit#3591

Merged
parulbajaj01 merged 1 commit into
GoogleCloudPlatform:developfrom
parulbajaj01:gke-sa-account
Jan 28, 2025
Merged

Fixed naming for deployment name in test to fit in size limit#3591
parulbajaj01 merged 1 commit into
GoogleCloudPlatform:developfrom
parulbajaj01:gke-sa-account

Conversation

@parulbajaj01

Copy link
Copy Markdown
Contributor

Changed deployment name for gke-a2high-kueue test to fit in size limit

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@parulbajaj01 parulbajaj01 added the release-improvements Added to release notes under the "Improvements" heading. label Jan 27, 2025
@annuay-google

Copy link
Copy Markdown
Contributor

Changes LGTM, please re-run the breaking IT

@parulbajaj01

Copy link
Copy Markdown
Contributor Author

Re-ran it, passing now

@annuay-google annuay-google left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parulbajaj01 parulbajaj01 merged commit 509011f into GoogleCloudPlatform:develop Jan 28, 2025
@abbas1902 abbas1902 mentioned this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants