Skip to content

Replace Spack w/ Enroot/pyxis for NCCL tests#3589

Merged
tpdownes merged 1 commit into
GoogleCloudPlatform:developfrom
samskillman:fix/a3u-slurm-gcs-nccl-test
Jan 27, 2025
Merged

Replace Spack w/ Enroot/pyxis for NCCL tests#3589
tpdownes merged 1 commit into
GoogleCloudPlatform:developfrom
samskillman:fix/a3u-slurm-gcs-nccl-test

Conversation

@samskillman

Copy link
Copy Markdown
Collaborator

This speeds up the test duration, as well as resolves issues encountered between compatibility of spack-installed mpi/slurm w/ existing slurm enviornment.

Has been manually tested on a fresh a3u-slurm-ubuntu-gcs cluster.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

This speeds up the test duration, as well as resolves issues encountered
between compatibility of spack-installed mpi/slurm w/ existing slurm
enviornment.
@samskillman samskillman requested a review from tpdownes January 25, 2025 22:03
@samskillman samskillman added the release-bugfix Added to release notes under the "Bug fixes" heading. label Jan 26, 2025
@tpdownes tpdownes self-assigned this Jan 27, 2025
@tpdownes tpdownes added release-improvements Added to release notes under the "Improvements" heading. and removed release-bugfix Added to release notes under the "Bug fixes" heading. labels Jan 27, 2025
@tpdownes tpdownes merged commit 9c3cc6e into GoogleCloudPlatform:develop Jan 27, 2025
@abbas1902 abbas1902 mentioned this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants