Add integration test for a3ultra-vm.yaml#3579
Merged
RachaelSTamakloe merged 1 commit intoJan 27, 2025
Merged
Conversation
2f5e7fd to
eabcb68
Compare
tpdownes
suggested changes
Jan 24, 2025
tpdownes
left a comment
Contributor
There was a problem hiding this comment.
Can you please split the changes to modules/compute/vm-instance/* into a separate PR? Additionally, we've now introduced a situation where the following input variables may have user confusion:
- var.spot
- var.reservation_name
- var.reservation_bound
Let's discuss offline how to guide away from user confusion.
eabcb68 to
4764eea
Compare
tpdownes
suggested changes
Jan 25, 2025
4764eea to
c5459c8
Compare
tpdownes
approved these changes
Jan 27, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an integration test for the a3ultra-vm.yaml blueprint. The integration test deploys the a3ultra-vm.yaml blueprint and runs
nvidia-smionremote_node: "{{ hostname_prefix }}-0".Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.