Skip to content

Adding a note to use of Private Service Access module#3527

Merged
RachaelSTamakloe merged 1 commit into
GoogleCloudPlatform:developfrom
RachaelSTamakloe:Private_Service_Access
Jan 17, 2025
Merged

Adding a note to use of Private Service Access module#3527
RachaelSTamakloe merged 1 commit into
GoogleCloudPlatform:developfrom
RachaelSTamakloe:Private_Service_Access

Conversation

@RachaelSTamakloe

@RachaelSTamakloe RachaelSTamakloe commented Jan 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR adds variations of the below note to examples that reference the community/modules/network/private-service-access module.

  # Private Service Access (PSA) requires the compute.networkAdmin role which is included in the Owner role, but not Editor
  # PSA is a best practice for Filestore instances, but can be optionally
  # removed by deleting the private_service_access module and any references to the module
  # by Filestore modules. PSA is required for all Parallelstore functionality.
  # https://cloud.google.com/vpc/docs/configure-private-services-access#permissions
  - id: private_service_access
    source: community/modules/network/private-service-access
    use: [network]

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@RachaelSTamakloe RachaelSTamakloe added the release-module-improvements Added to release notes under the "Module Improvements" heading. label Jan 11, 2025
tpdownes
tpdownes suggested changes Jan 13, 2025
View reviewed changes

@tpdownes tpdownes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Edit the comment in blueprints without Filestore so that it does not mention Filestore
  2. "change "deleting the following 3 lines" to somethign that is more accurate across all blueprints. I suggest "delete the private-service-access module" but please make a choice based on thorough review.
  3. Formatting suggestion

The first line in this comment is quite long. Please format whole comment so no line is more than 80 characters long and the URL remains on its own line.

  # Private Service Access (PSA) requires the compute.networkAdmin role which is included in the Owner role, but not Editor
  # PSA is a best practice for Filestore instances, but can be optionally
  # removed by deleting the following 3 lines and any references to the module
  # by Filestore modules. PSA is required for all Parallelstore functionality.
  # https://cloud.google.com/vpc/docs/configure-private-services-access#permissions

Comment thread examples/gke-managed-parallelstore.yaml Outdated
Comment thread examples/pfs-parallelstore.yaml Outdated
Comment thread examples/ps-slurm.yaml Outdated
Comment thread modules/file-system/gke-storage/README.md Outdated
@RachaelSTamakloe RachaelSTamakloe merged commit 495ddc8 into GoogleCloudPlatform:develop Jan 17, 2025
@abbas1902 abbas1902 mentioned this pull request Feb 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tpdownes tpdownes tpdownes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@RachaelSTamakloe RachaelSTamakloe

Labels

release-module-improvements Added to release notes under the "Module Improvements" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RachaelSTamakloe @tpdownes