Skip to content

Update Minimum terraform version in Makefile from 1.2 to 1.5.7#3526

Merged
RachaelSTamakloe merged 1 commit into
GoogleCloudPlatform:developfrom
RachaelSTamakloe:min_terraform_version
Jan 13, 2025
Merged

Update Minimum terraform version in Makefile from 1.2 to 1.5.7#3526
RachaelSTamakloe merged 1 commit into
GoogleCloudPlatform:developfrom
RachaelSTamakloe:min_terraform_version

Conversation

@RachaelSTamakloe

@RachaelSTamakloe RachaelSTamakloe commented Jan 10, 2025

Copy link
Copy Markdown
Collaborator

This PR updates the MIN_TERRAFORM_VERSION in Makefile from v1.2 to v1.5.7 as documented here.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@RachaelSTamakloe RachaelSTamakloe added the release-version-updates Added to release notes under the "Version Updates" heading. label Jan 10, 2025

@tpdownes tpdownes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I observe the proper warning after installing Terraform 1.5.6 and Terraform 1.2.0:

~/cluster-toolkit (min_terraform_version)❯❯❯ make && make install
Makefile:153: WARNING: terraform version must be greater than 1.5.7 , update at https://learn.hashicorp.com/tutorials/terraform/install-cli

I do not observe this on latest (1.10.4) or 1.5.7.

@RachaelSTamakloe RachaelSTamakloe merged commit 14c72ac into GoogleCloudPlatform:develop Jan 13, 2025
@abbas1902 abbas1902 mentioned this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-version-updates Added to release notes under the "Version Updates" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants