SlurmGCP. Deprecate enable_smt, add advanced_machine_features#3525
Merged
Conversation
alyssa-sm
approved these changes
Jan 14, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Allow users to specify all aspects of
advanced_machine_features, not only partially (null / 1)threads_per_core.This enables us to remove
pmu_plugin.UX changes:
Since we disable SMT by default, the default value for
advanced_machine_featuresis{ threads_per_core = 1 # disable SMT by default }To enable SMT user would need to specify following: