Use version prefix in conjunction with release channels#3520
Merged
annuay-google merged 1 commit intoJan 9, 2025
Merged
Conversation
ankitkinra
reviewed
Jan 9, 2025
ankitkinra
approved these changes
Jan 9, 2025
ac1b2f6 to
443b895
Compare
chengcongdu
reviewed
Jan 13, 2025
| variable "version_prefix" { | ||
| description = "If provided, Terraform will only return versions that match the string prefix. For example, `1.31.` will match all `1.31` series releases. Since this is just a string match, it's recommended that you append a `.` after minor versions to ensure that prefixes such as `1.3` don't match versions like `1.30.1-gke.10` accidentally." | ||
| type = string | ||
| default = "1.31." |
Member
There was a problem hiding this comment.
I don't think we should have a default value for this, GKE is continually upgrading and it has its own default version when customer not specifying
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use min master version in conjunction with Rapid release channel
Testing
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.