Enable hierarchical namespace support in cloud-storage-bucket module#3513
Conversation
…hierarchical namespace
tpdownes
left a comment
There was a problem hiding this comment.
The documentation says this option must be enabled at creation?
Can you document the UX for the following steps:
- Create a bucket without HNS?
- Add some objects to it manually (outside terraform)
- Using terraform, enable HNS on the existing bucket
My hope is that, either the API fails entirely with a clear-ish error message or, at least, the bucket destruction fails because there are existing objects in the bucket that Terraform doesn't know about.
Additionally add some short text to the variable description saying that the option must be set at first creation of the bucket.
|
The UX is as follows.
On step 3, the existing bucket without HNS got destroyed and was replaced by a new bucket with HNS enabled. The document uploaded on step 2 is lost. No exclusive warning or error observed. |
tpdownes
left a comment
There was a problem hiding this comment.
I have some concerns about the lifecycle of changing this settings, but let's document and prioritize that as follow-up work.
Some further examination suggests that force_destroy was set to true during this test, so the observed behavior is expected. We will follow up to confirm that objects outside Terraform are not destroyed if force_destroy is set to false (default value). |
|
Tested out the UX when the force_destroy is set to false, and it gave out an error. Error: exit status 1 |
Enable hierarchical namespace support in cloud-storage-bucket module.
Boolean variable "enable_hierarchical_namespace" with default 'false', that links to this setting in the Terraform resource.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.