Skip to content

Remove slurm-gcp v5 tests#3493

Merged
harshthakkar01 merged 1 commit into
GoogleCloudPlatform:developfrom
harshthakkar01:remove-v5-tests
Jan 6, 2025
Merged

Remove slurm-gcp v5 tests#3493
harshthakkar01 merged 1 commit into
GoogleCloudPlatform:developfrom
harshthakkar01:remove-v5-tests

Conversation

@harshthakkar01

@harshthakkar01 harshthakkar01 commented Jan 6, 2025

Copy link
Copy Markdown
Contributor

Cloud Build triggers for slurm-gcp v5 are removed.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@harshthakkar01 harshthakkar01 added the release-deprecations Added to release notes under the "Deprecations" heading. label Jan 6, 2025

@tpdownes tpdownes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpdownes tpdownes assigned harshthakkar01 and unassigned tpdownes Jan 6, 2025
@harshthakkar01 harshthakkar01 merged commit 62e2962 into GoogleCloudPlatform:develop Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-deprecations Added to release notes under the "Deprecations" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants