Skip to content

Placement policy null condition checks added#3459

Merged
ighosh98 merged 1 commit into
GoogleCloudPlatform:developfrom
ighosh98:placement-policy
Dec 24, 2024
Merged

Placement policy null condition checks added#3459
ighosh98 merged 1 commit into
GoogleCloudPlatform:developfrom
ighosh98:placement-policy

Conversation

@ighosh98

Copy link
Copy Markdown
Contributor

Saw build failures as the earlier PR didn't account for null condition checks. Add null checks wherever applicable in the placement_policy checks.

Callout: Today, we only support COMPACT placement policy. However, this may change in the future. Hence, chose not to update the condition associated with placement_policy check.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@ighosh98 ighosh98 requested a review from ankitkinra December 23, 2024 22:00
@ighosh98 ighosh98 added the release-bugfix Added to release notes under the "Bug fixes" heading. label Dec 23, 2024
@ighosh98 ighosh98 merged commit 2654309 into GoogleCloudPlatform:develop Dec 24, 2024
@ighosh98 ighosh98 deleted the placement-policy branch March 29, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-bugfix Added to release notes under the "Bug fixes" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants