Update A3U blueprint to remove commit refs and remove hardcoded network names#3456
Merged
Merged
Conversation
6642287 to
72ac71e
Compare
ankitkinra
approved these changes
Dec 22, 2024
mohitchaurasia91
approved these changes
Dec 23, 2024
Contributor
Author
|
Additional validations regarding variable length would be evaluated in a follow up PR. Merging this one to unblock other developers |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ties variable names to dynamic deployment_variables instead of hard coded values. This ensures that collisions do not occur when users use cluster-toolkit to provision multiple clusters within the same project.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.