Add a3u-gke-gcs blueprint#3454
Merged
samskillman merged 15 commits intoJan 21, 2025
Merged
Conversation
ffc05d1 to
c65f2cc
Compare
ighosh98
reviewed
Dec 21, 2024
ankitkinra
reviewed
Dec 22, 2024
chengcongdu
reviewed
Dec 26, 2024
saikat-royc
reviewed
Jan 7, 2025
saikat-royc
reviewed
Jan 7, 2025
ankitkinra
reviewed
Jan 8, 2025
ankitkinra
left a comment
Contributor
There was a problem hiding this comment.
LGTM but will allow storage experts to approve.
We should try to create an e2e integration test for this blueprint as soon as can.
9dc3cb9 to
443ac98
Compare
Also adopt latest nccl-rdma installer.
443ac98 to
ee88546
Compare
Collaborator
Author
|
Rebased on top of current |
ighosh98
reviewed
Jan 17, 2025
Simplify nemo examples, add instructions to get ramble workspace.
ighosh98
approved these changes
Jan 20, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to the blueprint, which gives an opinionated way to mount buckets for training and checkpointing, I modified the gke-persistent-volume to be able to use the mount_options specified in network_storage. It previously just hardcoded implicit-dirs.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.