Fix non-constant format string errors#3451
Merged
mr0re1 merged 2 commits intoDec 20, 2024
Merged
Conversation
mr0re1
reviewed
Dec 20, 2024
Collaborator
|
Hi @chajath , thank you for PR ! I left one comment, do you mind to address it? Otherwise looks good. |
mr0re1
approved these changes
Dec 20, 2024
Collaborator
|
/gcbrun |
Collaborator
|
/gcbrun |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
veterror due to: golang/go#60529See https://tip.golang.org/doc/go1.24#:~:text=Vet%C2%B6,%2360529.
Go build on 1.22 and 1.23 are not blocked per se as vet of the older golang doesn't check for the error, but it's nice-to-have fix anyway and makes the code forward-compatible with 1.24.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.