Skip to content

Fix non-constant format string errors#3451

Merged
mr0re1 merged 2 commits into
GoogleCloudPlatform:developfrom
chajath:chajath/fix-unittest-const-str
Dec 20, 2024
Merged

Fix non-constant format string errors#3451
mr0re1 merged 2 commits into
GoogleCloudPlatform:developfrom
chajath:chajath/fix-unittest-const-str

Conversation

@chajath

@chajath chajath commented Dec 20, 2024

Copy link
Copy Markdown
Contributor

Fix vet error due to: golang/go#60529
See https://tip.golang.org/doc/go1.24#:~:text=Vet%C2%B6,%2360529.

Go build on 1.22 and 1.23 are not blocked per se as vet of the older golang doesn't check for the error, but it's nice-to-have fix anyway and makes the code forward-compatible with 1.24.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

Comment thread pkg/modulereader/hcl_utils.go Outdated
@mr0re1

mr0re1 commented Dec 20, 2024

Copy link
Copy Markdown
Collaborator

Hi @chajath , thank you for PR ! I left one comment, do you mind to address it? Otherwise looks good.

@mr0re1 mr0re1 self-assigned this Dec 20, 2024
@mr0re1 mr0re1 added the release-chore To not include into release notes label Dec 20, 2024
@mr0re1

mr0re1 commented Dec 20, 2024

Copy link
Copy Markdown
Collaborator

/gcbrun

@mr0re1

mr0re1 commented Dec 20, 2024

Copy link
Copy Markdown
Collaborator

/gcbrun

@mr0re1 mr0re1 enabled auto-merge December 20, 2024 22:16
@mr0re1 mr0re1 merged commit 32bb80e into GoogleCloudPlatform:develop Dec 20, 2024
@chajath chajath deleted the chajath/fix-unittest-const-str branch December 30, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-chore To not include into release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants